Skip to content

feat(sdk): expose SRT signer#329

Merged
strantalis merged 2 commits intomainfrom
dspx-2211/srt-signer
Jan 20, 2026
Merged

feat(sdk): expose SRT signer#329
strantalis merged 2 commits intomainfrom
dspx-2211/srt-signer

Conversation

@strantalis
Copy link
Copy Markdown
Member

@strantalis strantalis commented Jan 20, 2026

No description provided.

@strantalis
feat(sdk): expose SRT signer
13796c8 
Signed-off-by: strantalis <strantalis@virtru.com>
@strantalis strantalis requested review from a team as code owners January 20, 2026 16:34
cshamrick
cshamrick previously approved these changes Jan 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cshamrick cshamrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@strantalis
Copy link
Copy Markdown
Member Author

strantalis commented Jan 20, 2026

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable feature by allowing a custom SRT (Signed Request Token) signer to be provided to the SDK. The implementation is well-structured, introducing a new SrtSigner interface and a default implementation, and integrating it cleanly into the SDKBuilder and KASClient. The changes also include comprehensive tests for the new functionality.

My review includes a few suggestions to enhance the API design by using more specific exception types, which will improve code clarity and robustness, and a recommendation for improving test code quality. Overall, this is a solid contribution.

Comment thread sdk/src/main/java/io/opentdf/platform/sdk/KASClient.java Outdated
Comment thread sdk/src/main/java/io/opentdf/platform/sdk/SrtSigner.java Outdated
Comment thread sdk/src/test/java/io/opentdf/platform/sdk/KASClientTest.java Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 20, 2026

X-Test Results

✅ go-v0.4.34
✅ js-v0.4.34
✅ java-v0.4.34
✅ js-main
✅ go-main
✅ java-main

@strantalis
fix(sdk): narrow SRT signer exceptions
579d667 
Signed-off-by: strantalis <strantalis@virtru.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 20, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
77.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cshamrick cshamrick self-requested a review January 20, 2026 18:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 20, 2026

X-Test Results

✅ go-v0.4.34
✅ js-v0.4.34
✅ java-v0.4.34
✅ js-main
✅ go-main
✅ java-main

@strantalis strantalis merged commit f93d332 into main Jan 20, 2026
17 of 18 checks passed
@strantalis strantalis deleted the dspx-2211/srt-signer branch January 20, 2026 20:03
@strantalis
Copy link
Copy Markdown
Member Author

strantalis commented Jan 21, 2026

/backport

@opentdf-automation
Copy link
Copy Markdown
Contributor

opentdf-automation bot commented Jan 21, 2026

Backport failed for releast/v0.12: couldn't find remote ref releast/v0.12.
Please ensure that this Github repo has a branch named releast/v0.12.

@strantalis
Copy link
Copy Markdown
Member Author

strantalis commented Jan 21, 2026

/backport

opentdf-automation bot pushed a commit that referenced this pull request Jan 21, 2026
@strantalis @github-actions
feat(sdk): expose SRT signer (#329)
e6c84b8 
Signed-off-by: strantalis <strantalis@virtru.com>
(cherry picked from commit f93d332)
@opentdf-automation
Copy link
Copy Markdown
Contributor

opentdf-automation bot commented Jan 21, 2026

Successfully created backport PR for release/v0.12:

@opentdf-automation opentdf-automation bot mentioned this pull request Jan 21, 2026
Open
opentdf-automation bot added a commit that referenced this pull request Jan 21, 2026
@opentdf-automation
feat(sdk): expose SRT signer (#329)
1dc3bf6 
Signed-off-by: strantalis <strantalis@virtru.com>
(cherry picked from commit f93d332)
@opentdf-automation opentdf-automation bot mentioned this pull request Apr 9, 2026
Merged
marythought pushed a commit that referenced this pull request Apr 9, 2026
@opentdf-automation
chore(main): release 0.13.0 (#327)
c0d7f7f 
🤖 I have created a release *beep* *boop*
---


<details><summary>0.13.0</summary>

##
[0.13.0](v0.12.0...v0.13.0)
(2026-04-09)


### Features

* **sdk:** add EntityIdentifier convenience constructors
([#346](#346))
([eeb8805](eeb8805))
* **sdk:** DSPX-2418 add discovery convenience methods
([#339](#339))
([8de6068](8de6068))
* **sdk:** expose SRT signer
([#329](#329))
([f93d332](f93d332))


### Bug Fixes

* add a default assertion id if one is not specified
([#341](#341))
([69d6a53](69d6a53))
* **docs:** DSPX-2409 replace SDK README code example with working code
([#336](#336))
([0f224a6](0f224a6))
* **sdk:** Support kas keys with extended EC methods
([#344](#344))
([982b287](982b287))
* **sdk:** Support RSA4096 Kas keys
([#343](#343))
([dba9bbf](dba9bbf))
* **sdk:** Updates to proto version v0.16.0
([#308](#308))
([4660e27](4660e27))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
@opentdf-automation opentdf-automation bot mentioned this pull request Apr 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cshamrick cshamrick cshamrick approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport release/v0.12

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@strantalis @cshamrick